@W-17291595: [iOS] [Instrumentation] Add QR Code feature logging to track adoption #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpage
reviewed
Dec 31, 2024
| @@ -422,6 +424,7 @@ - (BOOL)loginWithCompletion:(SFUserAccountManagerSuccessCallbackBlock)completion | |||
| frontDoorBridgeUrl:(nullable NSURL * )frontDoorBridgeUrl | |||
| codeVerifier:(nullable NSString *)codeVerifier | |||
| { | |||
| [SFSDKAppFeatureMarkers registerAppFeature:kSFAppFeatureQrCodeLogin]; | |||
There was a problem hiding this comment.
Similar to my comment on your Android PR is there anywhere QR Code specific we could put this instead? I did a quick search and didn't find anything (and also noticed that the isQrCodeLoginEnabled property in SalesforceSDKManager is never set/used anywhere 👀).
There was a problem hiding this comment.
It's a little tricky to find since the iOS side has more layers of abstraction even before QR Code Login was introduced. It's there, though. Take a look at ac87637
…rack adoption (Move QR Code Login feature tracking to a more specifically named location.)
brandonpage
approved these changes
Jan 3, 2025
JohnsonEricAtSalesforce
deleted the
feature/w-17291595_ios-instrumentation-add-qr-code-feature-logging-to-track-adoption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 _Ready For Review_ 🥁
This is a counterpart for forcedotcom/SalesforceMobileSDK-Android#2647