NEW (pmd): @W-17310954@ Adding in some more AppExchange Security rules #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests https://pmd.sourceforge.net/rule-tests_1_0_0.xsd"> | ||
|
|
||
| <!-- TOOD: STILL NEED TESTS FOR THIS RULE --> |
There was a problem hiding this comment.
Still waiting for Ravindra on these tests - but it sounds like it'll take a while for him to get to this... so just leaving it as a TODO for now.
| @@ -408,7 +427,7 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin | |||
| tags: [/* NOT RECOMMENDED */ APP_EXCHANGE_TAG, COMMON_TAGS.CATEGORIES.SECURITY, COMMON_TAGS.LANGUAGES.XML] | |||
| }, | |||
|
|
|||
| "AvoidDisableProtocolSecurity": { | |||
| "AvoidDisableProtocolSecurityRemoteSiteSetting": { | |||
There was a problem hiding this comment.
Ravindra renamed a few rules to be more specific. I agree with the renames and I think we are fine to do this during Beta.
stephen-carter-at-sf
force-pushed
the
sc/W-17310954
branch
from
c4cbc77 to
851adf5
Compare
jag-j
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.