Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: snapshot wave bundles #1390

Merged
merged 6 commits into from
Aug 8, 2024
Merged

test: snapshot wave bundles #1390

merged 6 commits into from
Aug 8, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Aug 7, 2024

What does this PR do?

snapshot tests for waveTemplateBundle

  • type is odd, even for bundle, because it's a bundle but it has no meta.xml file.
  • adds the snaphots to prettier/eslint ignore to preserve formatting through commit/push hooks

What issues does this PR fix or reference?

@W-16396754@

@mshanemc mshanemc requested a review from a team as a code owner August 7, 2024 21:48
@mshanemc mshanemc changed the title Sm/snapshots bundles test: snapshot wave bundles Aug 7, 2024
@shetzel shetzel merged commit 4bf977b into main Aug 8, 2024
77 checks passed
@shetzel shetzel deleted the sm/snapshots-bundles branch August 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshanemc @shetzel @WillieRuemmele @svc-cli-bot