Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate manifestComponents consistently #1481

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

WillieRuemmele
Copy link
Member

@WillieRuemmele WillieRuemmele commented Jan 9, 2025

What does this PR do?

ensures the generated manifests are the same, when using --post/pre destructive changes or not

What issues does this PR fix or reference?

@W-17425220@

Functionality Before

would NOT error when using --post/pre when a constructive manifest had a typo
would parse out typo (as it wasn't found locally) from the manifest sent to the server, and deployment would succeed

Functionality After

will send typo to server, and allow it to error there

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner January 9, 2025 22:41
@shetzel
Copy link
Contributor

shetzel commented Jan 10, 2025

QA
package.xml has an invalid entry (e.g., misspelled ApexClass)

sf project deploy start -x package.xml -> failed deploy as expected
sf project deploy start -x package.xml --post-destructive-changes pkg.xml -> failed deploy as expected

@shetzel shetzel merged commit 84ba5bd into main Jan 10, 2025
51 checks passed
@shetzel shetzel deleted the wr/consistentManifestConstruction branch January 10, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants