Add sources in default card #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you remove the |
ebefarooqui
reviewed
Oct 22, 2021
| ...CardProps, | ||
| export const DefaultCard = Template.bind({}); | ||
| DefaultCard.args = { | ||
| content: generateCardLayout['default']({ |
There was a problem hiding this comment.
Could you move this block out to a separate file? Namely, the mock data here
ebefarooqui
reviewed
Oct 22, 2021
| @@ -29,11 +26,6 @@ export const Card = ({ | |||
| /> | |||
| ); | |||
|
|
|||
| const renderCaret = () => | |||
There was a problem hiding this comment.
Is there a rationale here for removing the caret? I think it's useful, especially when the user begins to tack on enough sources forcing the user to scroll past every source when attempting to access a card further below in the stack. This is currently a visual issue with the yemen platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the default card so that it lays out sources inline in the card. It's fairly lo-fi for now, but it should at least return the ability to use sources in the canonical timemap format.
(Note that the markdown and image sources here are due to the local URLs in the example datasheet-server sheet: I'll update those to remote URLs so that the whole ecosystem works better for new users 'out-of-the-box'.)