Add e2e test via Github workflow #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foresterre
force-pushed
the
e2e
branch
5 times, most recently
from
c028b32 to
18aa127
Compare
|
It's unclear why the windows runner fails to install toolchains thus far. For now it is noted as a known issue. Help is welcome! I will continue investigating. The windows workflow is not required to pass until we fix this. |
In #1036, an issue was reported which reported toolchain install issues, possibly caused by path separator issues on windows (ubuntu and mac seem to be fine). With this commit, we add a run of cargo-msrv as an e2e test to our own CI on windows and mac while we're at it. Previously, we would only run on ubuntu; the e2e test was a side-effect of checking our own MSRV. We do have tests which run via the 'cargo run' vehicle and temporary directories, but that's not as sandboxed as this approach. Hopefully, running all primary platforms will (1) give an indication of whether #1036 is indeed a cargo-msrv issue, and (2) prevent similar bugs in the future.
Includes: - Add span to RustupCommand - Canonicalized path if canonicalize succeeds, otherwise falls back to using the input path
The workaround doesn't work.
A workaround which may or may not work :)
To be consistent with what cargo-msrv does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1036, an issue was reported which reported toolchain install issues, possibly caused by path separator issues on windows (ubuntu and mac seem to be fine).
With this commit, we add a run of cargo-msrv as an e2e test to our own CI on windows and mac while we're at it. Previously, we would only run on ubuntu; the e2e test was a side-effect of checking our own MSRV. We do have tests which run via the 'cargo run' vehicle and temporary directories, but that's not as sandboxed as this approach.
Hopefully, running all primary platforms will (1) give an indication of whether #1036 is indeed a cargo-msrv issue, and (2) prevent similar bugs in the future.