infra: Remove nightly from ci-test workflow #826
Merged
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of cargo msrv tests is currently different on nightly, compared to stable (and beta). As such, some of our end-to-end tests were failing. Nightly is only a nice to have for now, and handling the output separately is not in my best interest regarding time management. As such, I decided to remove it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 81 81
Lines 6057 6057
=======================================
Hits 4587 4587
Misses 1470 1470 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of cargo msrv tests is currently different on nightly, compared to stable (and beta). As such, some of our end-to-end tests were failing. Nightly is only a nice to have for now, and handling the output separately is not in my best interest regarding time management. As such, I decided to remove it.