Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): add CONSOLE_COOKIE_DOMAIN #105

Merged

Conversation

Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Feb 5, 2025

No description provided.

@Dav-14 Dav-14 requested a review from a team as a code owner February 5, 2025 09:23
Copy link

coderabbitai bot commented Feb 5, 2025

Walkthrough

The pull request updates version information in multiple documentation files for several Helm charts. Specifically, it increments the versions for the Cloudprem, Console-V3, and Portal charts and updates application version hashes for Console-V3 and Portal. Additionally, a new environment variable (CONSOLE_COOKIE_DOMAIN) is introduced in the Portal chart's cookie template, conditioned on the console platform being enabled.

Changes

Files Change Summary
README.md Updated Helm chart versions for Cloudprem (3.0.0-rc.8 → 3.0.0-rc.9), Console-V3 (2.0.1 → 2.0.2, app version updated), and Portal (2.0.3 → 2.0.4, app version updated).
charts/cloudprem/README.md, charts/console-v3/README.md, charts/portal/README.md - Cloudprem: Version badge update from 3.0.0-rc.8 to 3.0.0-rc.9.
- Console-V3: Version and AppVersion increment from 2.0.1 to 2.0.2 and updated hash.
- Portal: Version and AppVersion increment from 2.0.3 to 2.0.4 and updated hash.
charts/portal/templates/_helpers.tpl Added a new environment variable CONSOLE_COOKIE_DOMAIN in the portal.cookie template, set to {{ .Values.global.serviceHost }} when the console platform is enabled.

Possibly related PRs

Suggested labels

bug, docs, feature, release

Suggested reviewers

  • flemzord

Poem

I'm a little rabbit with a code-loving heart,
Hopping through charts with a joyful restart.
Bumps in versions, new settings in play,
Each change sings a tune in its own special way.
A whisker twitch, a hop so neat—
Celebrating fresh code with a happy beat!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4cbd80 and 5348802.

⛔ Files ignored due to path filters (4)
  • charts/cloudprem/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/cloudprem/Chart.yaml is excluded by !**/*.yaml
  • charts/console-v3/Chart.yaml is excluded by !**/*.yaml
  • charts/portal/Chart.yaml is excluded by !**/*.yaml
📒 Files selected for processing (5)
  • README.md (1 hunks)
  • charts/cloudprem/README.md (1 hunks)
  • charts/console-v3/README.md (1 hunks)
  • charts/portal/README.md (1 hunks)
  • charts/portal/templates/_helpers.tpl (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • charts/console-v3/README.md
  • charts/portal/README.md
  • README.md
  • charts/cloudprem/README.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Tests
🔇 Additional comments (1)
charts/portal/templates/_helpers.tpl (1)

55-56: LGTM! The addition of CONSOLE_COOKIE_DOMAIN aligns with the documented requirements.

The change correctly implements cookie domain distinction by:

  • Adding it within the console platform enabled block
  • Using the global service host as the domain value
  • Following the documented requirement for cookie distinction (see comment on line 27)

However, please verify that .Values.global.serviceHost is always set when console platform is enabled.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added bug Something isn't working docs release labels Feb 5, 2025
@reslene reslene self-requested a review February 5, 2025 09:23
@Dav-14 Dav-14 enabled auto-merge February 5, 2025 09:24
@Dav-14 Dav-14 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 0b6c731 Feb 5, 2025
5 checks passed
@Dav-14 Dav-14 deleted the fix/pla-227-fixportal-add-console_cookie_domain-env-variable branch February 5, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants