Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7112: fixed issues with calendar widget display for value components in new simple conditionals ui #5402

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

TanyaGashtold
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7112

Description

What changed?

TextField component should inherit the widget settings of the original form component in new simple conditionals ui.
Base value component in new simple conditionals ui should always has input widget.

Dependencies

https://github.com/formio/premium/pull/279

How has this PR been tested?

manually

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…idget after the condition base component is changed to the component without widget
@TanyaGashtold TanyaGashtold changed the title FIO-7112: fixed an issue where value component still shows calendar widget after the condition base component is changed to the component without widget FIO-7112: fixed issues with calendar widget display for value components in new simple conditionals ui Nov 13, 2023
@TanyaGashtold
Copy link
Contributor Author

image
All tests passed locally

@HannaKurban HannaKurban merged commit ca7509a into master Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants