Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7642: fixed issues where calculated value with allow override is not recalculated after form/component/row values are reset #5444

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Jan 5, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7642

Description

What changed?

This PR resets calculated value (so that the calculations could start again and were not considered as overridden) when the manual override is enabled in the following cases:

  • when the component becomes hidden and clearOnHide enabled
  • when a user clicks cancel button for wizard
  • when component or form is reset (e.g. by clicking on the button with reset action)
  • when a user cancel the row in the dataGrid

How has this PR been tested?

Manually + added tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…not recalculated after form/component/row values are reset
@alexandraRamanenka alexandraRamanenka merged commit ec40417 into master Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants