Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9482 fixed setting Formio version #5974

Merged

Conversation

HannaKurban
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9482

Description

Fixed setting the Formio.version property. Previously the Formio.version property was set as 'FORMIO_VERSION' and was not overwritten according to the version installed in package.json during the build process. This meant that the grid library was loaded only from cdn.form.io (instead of cdn.test-form.io for testing), because 'FORMIO_VERSION' doesn't include 'rc'. It was fixed by adding a gulp task and replacing the static 'FORMIO_VERSION' with the appropriate FJS version.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

All tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 6a5e5bc into master Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants