Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8548: Update choices.js to 11 version #5976

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Jan 13, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8548

Description

Updated choices.js to version 11. Reworked the ChoicesWrapper class. Completely reworked the Select component tests.

I was able to improve the test performance for the Select component by 2 times.
before:
image
after:
image

Dependencies

formio/Choices#3

How has this PR been tested?

Manual testing around ChoicesWrapper and fixed unit tests.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@roma-formio roma-formio changed the title [DO_NOT_MERGE] FIO-8548: updated choices.js to 11 version [DO_NOT_MERGE] FIO-8548: Update choices.js to 11 version Jan 13, 2025
@roma-formio roma-formio changed the title [DO_NOT_MERGE] FIO-8548: Update choices.js to 11 version FIO-8548: Update choices.js to 11 version Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant