Test cases for updating ThreatOracle address

forta-network · Dec 4, 2023 · 8f24142 · 8f24142
1 parent d4ed4af
commit 8f24142
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/scripts/deployments/platform.js b/scripts/deployments/platform.js
@@ -293,10 +293,12 @@ async function migrate(config = {}) {
 
         const minConfidenceScore = 90;
         const maxAddressArgumentAmount = 50;
+        const managerAddress = (await ethers.getSigners())[1];
+
         contracts.oracleConsumer = await contractHelpers.tryFetchContract(
             hre,
             'MockThreatOracleConsumer',
-            [contracts.threatOracle.address, minConfidenceScore, maxAddressArgumentAmount],
+            [contracts.threatOracle.address, minConfidenceScore, maxAddressArgumentAmount, managerAddress.address],
             CACHE
         );
 

diff --git a/test/components/threat.oracle.test.js b/test/components/threat.oracle.test.js
@@ -584,4 +584,33 @@ describe('Threat Oracle', async function () {
                 .to.be.revertedWith(`${MaxAddressArgumentAmountExceededSig}`);
         });
     });
+
+    describe.only('mock app suite', async function () {
+        it('allows contract owner to update the address for the ThreatOracle', async function () {
+            expect(await this.oracleConsumer.connect(this.accounts.user1).getThreatOracleAddress()).to.be.equal(this.threatOracle.address);
+
+            await expect(this.oracleConsumer.connect(this.accounts.manager).updateThreatOracleContractAddress(mockAccounts[0]))
+                .to.emit(this.oracleConsumer, 'ThreatOracleContractUpdated')
+                .withArgs(this.threatOracle.address, mockAccounts[0]);
+
+            expect(await this.oracleConsumer.connect(this.accounts.user1).getThreatOracleAddress()).to.be.equal(mockAccounts[0]);
+
+            // Change it back
+            await expect(this.oracleConsumer.connect(this.accounts.manager).updateThreatOracleContractAddress(this.threatOracle.address))
+                .to.emit(this.oracleConsumer, 'ThreatOracleContractUpdated')
+                .withArgs(mockAccounts[0], this.threatOracle.address);
+
+            expect(await this.oracleConsumer.connect(this.accounts.user1).getThreatOracleAddress()).to.be.equal(this.threatOracle.address);
+        });
+
+        it.only('blocks non-owner accounts from updating the address for the ThreatOracle', async function () {
+            expect(await this.oracleConsumer.connect(this.accounts.user1).getThreatOracleAddress()).to.be.equal(this.threatOracle.address);
+
+            await expect(this.oracleConsumer.connect(this.accounts.other).updateThreatOracleContractAddress(mockAccounts[0]))
+                .to.be.revertedWith(`MsgSenderNotOwner("${this.accounts.other.address}")`);
+
+            // Confirm it wasn't changed
+            expect(await this.oracleConsumer.connect(this.accounts.user1).getThreatOracleAddress()).to.be.equal(this.threatOracle.address);
+        });
+    });
 })