Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Signnup form in mobile view #697

Closed
wants to merge 1 commit into from
Closed

Fixed Signnup form in mobile view #697

wants to merge 1 commit into from

Conversation

plxity
Copy link
Member

@plxity plxity commented Jan 24, 2019 •
edited
Loading

Fixes #693

Changes: Made signup form aligned properly in mobile view

Screenshot:
capture

Surge Deployment Link: https://pr-697-fossasia-susi-accounts.surge.sh

samagragupta
samagragupta reviewed Jan 24, 2019
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot.

@plxity
Copy link
Member Author

plxity commented Jan 24, 2019

@samagragupta Done.

samagragupta
samagragupta reviewed Jan 25, 2019
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email
The width of the email and password textfield are different.

@plxity
Copy link
Member Author

plxity commented Jan 25, 2019

@samagragupta Wait, let me check!

@Orbiter
Copy link
Contributor

Orbiter commented Feb 2, 2019

please resolve conflicts

samagragupta
samagragupta suggested changes Feb 27, 2019
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

sakshee-19
sakshee-19 suggested changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@sakshee-19 sakshee-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts needs to be resolved.

AdityaSrivast
AdityaSrivast suggested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@AdityaSrivast AdityaSrivast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plxity Try to get rid of !important. Codacy failing.

rossoskull
rossoskull reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@rossoskull rossoskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates @plxity?

@mariobehling
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossoskull rossoskull rossoskull left review comments

@samagragupta samagragupta samagragupta requested changes

@AdityaSrivast AdityaSrivast AdityaSrivast requested changes

@sakshee-19 sakshee-19 sakshee-19 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signup form is not properly aligned in mobile view
7 participants
@plxity @Orbiter @mariobehling @sakshee-19 @rossoskull @AdityaSrivast @samagragupta