-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create speaker account with SSO as part of the answer to Call for Proposals #258
Conversation
Reviewer's Guide by SourceryThis pull request implements the "Register Speaker Account" button and modifies the "Login with SSO" button to redirect users back to the previous page after login. This addresses the issue where users were not able to create an account or login via SSO to submit a proposal. Sequence diagram for the updated SSO login flowsequenceDiagram
actor User
participant Browser
participant App
participant SSOProvider
User->>Browser: Click 'Login with SSO'
Browser->>App: GET /login/ with next_url
App->>App: Store next_url in session
App->>SSOProvider: Redirect to authorization URL
SSOProvider-->>Browser: Show login page
User->>SSOProvider: Enter credentials
SSOProvider-->>App: OAuth callback
App->>App: Process OAuth response
App->>App: Create/update user
App->>App: Retrieve next_url from session
App-->>Browser: Redirect to next_url
Browser-->>User: Show original page
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Validate next_url parameter to prevent open redirect vulnerabilities (link)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue, 1 other issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description:
The user is now required to login before submitting a proposal
This PR resolves #257
Summary by Sourcery
New Features: