fix(config): enable optimizer when optimizer_runs set in config

[yash-atreya]

Motivation

Closes #9665

Solution

• Change the optimizer and optimizer_runs keys to Option<bool> and Option<usize> respectively
• Detect whether the optimizer_runs key has been set in the config and is nonzero. If yes, then set config.optimizer = true.
• If optimizer = true but optimizer_runs has not been set. optimizers_runs will default to 200.

[zerosnacks]

Nice, lgtm!

[grandizzy]

lgtm! made some tests on sepolia base with deploying with different optimizer and optimizer_config settings and they behave properly

[elopez]

Hi folks @yash-atreya @zerosnacks @grandizzy, it looks like the change of optimizer to an Option<bool> also changed the format of on-disk hardhat-style build-info json artifacts, which affects external tooling (e.g. crytic/crytic-compile#581). Was that change intentional?

[grandizzy]

Hi folks @yash-atreya @zerosnacks @grandizzy, it looks like the change of optimizer to an Option<bool> also changed the format of on-disk hardhat-style build-info json artifacts, which affects external tooling (e.g. crytic/crytic-compile#581). Was that change intentional?

hi @elopez the change was intentional but we weren't aware of this side effect, will be looking into. Meanwhile you could just pin foundry to stable which doesn't contain the breaking changes (see announcement on top of release notes https://github.com/foundry-rs/foundry/releases/tag/stable)

[Missjones2829]

Merge