Use internal api in check validation (#2802)

<!-- Reference any GitHub issues resolved by this PR -->

## Introduced changes

<!-- A brief description of the changes -->

- Use internal `ScarbCommand` and `UniversalSierraCompilerCommand` for
`check-validation` instead of raw commands, which is required to fix
[snforge init test in the Scarb
repository](https://github.com/software-mansion/scarb/actions/runs/12406591491/job/34635305202)
- Remove unnecessary logic for the OS specific command (will be double
checked once we add Windows tests to CI)

crates/forge/src/compatibility_check.rs

@@ -1,13 +1,14 @@
 use anyhow::{anyhow, Context, Result};
 use regex::Regex;
 use semver::Version;
+use std::cell::RefCell;
 use std::process::Command;
 
 type VersionParser<'a> = dyn Fn(&str) -> Result<Version> + 'a;
 
 pub struct Requirement<'a> {
     pub name: String,
-    pub command: String,
+    pub command: RefCell<Command>,
     pub version_parser: Box<VersionParser<'a>>,
     pub helper_text: String,
     pub minimal_version: Version,
@@ -84,23 +85,9 @@ pub fn create_version_parser<'a>(name: &'a str, pattern: &'a str) -> Box<Version
     })
 }
 
-fn os_specific_command() -> Command {
-    if cfg!(target_os = "windows") {
-        let mut command = Command::new("cmd");
-        command.arg("/C");
-        command
-    } else {
-        let mut command = Command::new("sh");
-        command.arg("-c");
-        command
-    }
-}
-
-fn get_raw_version(name: &str, raw_command: &str) -> Result<String> {
-    let mut command = os_specific_command();
-    command.arg(raw_command);
-
+fn get_raw_version(name: &str, command: &RefCell<Command>) -> Result<String> {
     let raw_current_version = command
+        .borrow_mut()
         .output()
         .with_context(|| format!("Failed to run version command for {name}"))?;
     Ok(String::from_utf8_lossy(&raw_current_version.stdout)
@@ -111,13 +98,19 @@ fn get_raw_version(name: &str, raw_command: &str) -> Result<String> {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use scarb_api::ScarbCommand;
+    use universal_sierra_compiler_api::UniversalSierraCompilerCommand;
 
     #[test]
     fn happy_case() {
         let mut requirements_checker = RequirementsChecker::new(true);
         requirements_checker.add_requirement(Requirement {
             name: "Rust".to_string(),
-            command: "rustc --version".to_string(),
+            command: RefCell::new({
+                let mut cmd = Command::new("rustc");
+                cmd.arg("--version");
+                cmd
+            }),
             version_parser: create_version_parser(
                 "Rust",
                 r"rustc (?<version>[0-9]+.[0-9]+.[0-9]+)",
@@ -128,7 +121,7 @@ mod tests {
         });
         requirements_checker.add_requirement(Requirement {
             name: "Scarb".to_string(),
-            command: "scarb --version".to_string(),
+            command: RefCell::new(ScarbCommand::new().arg("--version").command()),
             minimal_version: Version::new(2, 7, 0),
             helper_text: "Follow instructions from https://docs.swmansion.com/scarb/download.html"
                 .to_string(),
@@ -139,7 +132,7 @@ mod tests {
         });
         requirements_checker.add_requirement(Requirement {
             name: "Universal Sierra Compiler".to_string(),
-            command: "universal-sierra-compiler --version".to_string(),
+            command: RefCell::new(UniversalSierraCompilerCommand::new().arg("--version").command()),
             minimal_version: Version::new(2, 0, 0),
             helper_text: "Reinstall `snforge` using the same installation method or follow instructions from https://foundry-rs.github.io/starknet-foundry/getting-started/installation.html#universal-sierra-compiler-update".to_string(),
             version_parser: create_version_parser(
@@ -161,7 +154,11 @@ mod tests {
         let mut requirements_checker = RequirementsChecker::new(true);
         requirements_checker.add_requirement(Requirement {
             name: "Rust".to_string(),
-            command: "rustc --version".to_string(),
+            command: RefCell::new({
+                let mut cmd = Command::new("rustc");
+                cmd.arg("--version");
+                cmd
+            }),
             version_parser: create_version_parser(
                 "Rust",
                 r"rustc (?<version>[0-9]+.[0-9]+.[0-9]+)",

crates/forge/src/lib.rs

@@ -7,9 +7,12 @@ use run_tests::workspace::run_for_workspace;
 use scarb_api::{metadata::MetadataCommandExt, ScarbCommand};
 use scarb_ui::args::{FeaturesSpec, PackagesFilter};
 use semver::Version;
+use std::cell::RefCell;
 use std::ffi::OsString;
+use std::process::Command;
 use std::{fs, num::NonZeroU32, thread::available_parallelism};
 use tokio::runtime::Builder;
+use universal_sierra_compiler_api::UniversalSierraCompilerCommand;
 
 pub mod block_number_map;
 mod combine_configs;
@@ -237,22 +240,26 @@ fn check_requirements(output_on_success: bool) -> Result<()> {
     let mut requirements_checker = RequirementsChecker::new(output_on_success);
     requirements_checker.add_requirement(Requirement {
         name: "Rust".to_string(),
-        command: "rustc --version".to_string(),
+        command: RefCell::new({
+            let mut cmd = Command::new("rustc");
+            cmd.arg("--version");
+            cmd
+        }),
         minimal_version: MINIMAL_RUST_VERSION,
         version_parser: create_version_parser("Rust", r"rustc (?<version>[0-9]+.[0-9]+.[0-9]+)"),
         helper_text: "Follow instructions from https://www.rust-lang.org/tools/install".to_string(),
     });
     requirements_checker.add_requirement(Requirement {
         name: "Scarb".to_string(),
-        command: "scarb --version".to_string(),
+        command: RefCell::new(ScarbCommand::new().arg("--version").command()),
         minimal_version: MINIMAL_SCARB_VERSION,
         helper_text: "Follow instructions from https://docs.swmansion.com/scarb/download.html"
             .to_string(),
         version_parser: create_version_parser("Scarb", r"scarb (?<version>[0-9]+.[0-9]+.[0-9]+)"),
     });
     requirements_checker.add_requirement(Requirement {
         name: "Universal Sierra Compiler".to_string(),
-        command: "universal-sierra-compiler --version".to_string(),
+        command: RefCell::new(UniversalSierraCompilerCommand::new().arg("--version").command()),
         minimal_version: MINIMAL_USC_VERSION,
         helper_text: "Reinstall `snforge` using the same installation method or follow instructions from https://foundry-rs.github.io/starknet-foundry/getting-started/installation.html#universal-sierra-compiler-update".to_string(),
         version_parser: create_version_parser(