Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped starknet-rs #2453

Merged
merged 17 commits into from
Sep 12, 2024
Merged

Bumped starknet-rs #2453

merged 17 commits into from
Sep 12, 2024

Conversation

integraledelebesgue
Copy link
Member

Closes #2352

Introduced changes

  • starknet-rs and starknet-crypto dependencies have been updated to the latest commit 660a732
  • test related to CASM artifact edge case is no longer ignored
  • A new Felt type replaced FieldElement
  • Appropriate changes in conversions crate

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

ksew1
ksew1 reviewed Sep 12, 2024
View reviewed changes
crates/sncast/src/helpers/braavos.rs Outdated Show resolved Hide resolved
crates/sncast/src/response/structs.rs Outdated Show resolved Hide resolved
crates/sncast/src/starknet_commands/call.rs Outdated Show resolved Hide resolved
crates/snforge-scarb-plugin/src/parse.rs Outdated Show resolved Hide resolved
ddoktorski
ddoktorski reviewed Sep 12, 2024
View reviewed changes
crates/sncast/src/helpers/fee.rs Outdated Show resolved Hide resolved
crates/sncast/tests/e2e/declare.rs Show resolved Hide resolved
crates/sncast/tests/integration/lib_tests.rs Show resolved Hide resolved
@integraledelebesgue integraledelebesgue mentioned this pull request Sep 12, 2024
Closed
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Sep 12, 2024
@integraledelebesgue integraledelebesgue removed this pull request from the merge queue due to a manual request Sep 12, 2024
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit 431d249 Sep 12, 2024
23 checks passed
@integraledelebesgue integraledelebesgue deleted the integraledelebesgue/fix-2352 branch September 12, 2024 14:02
@integraledelebesgue integraledelebesgue linked an issue Sep 13, 2024 that may be closed by this pull request
Make sncast declare work with scarb 2.7.0 #2352
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@ksew1 ksew1 Awaiting requested review from ksew1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sncast declare work with scarb 2.7.0
3 participants
@integraledelebesgue @ddoktorski @ksew1