-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run some checks on windows #2730
Conversation
Co-authored-by: Franciszek Job <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it would be better to test Windows only in the scheduled workflow. Testing it with every single change isn’t crucial and overall it will slow down our CI and make it harder to maintain.
Can we create an issue to investigate whether the cache action functions correctly, considering that the first CI run on a branch takes significantly longer than subsequent runs, and on Windows it is much longer than on Linux? Example: |
@ddoktorski I'd just merge this and we'll see if te build times are problematic. And if so, we can disable these checks at any time. |
# Conflicts: # CHANGELOG.md # Cargo.toml
# Conflicts: # CHANGELOG.md
Closes #2716
Introduced changes
Checklist
CHANGELOG.md