Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run some checks on windows #2730

Merged
merged 75 commits into from
Jan 10, 2025
Merged

Run some checks on windows #2730

merged 75 commits into from
Jan 10, 2025

Conversation

cptartur
Copy link
Member

Closes #2716

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

.github/workflows/ci.yml Outdated Show resolved Hide resolved
scripts/install_devnet.ps1 Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Franciszek Job <[email protected]>
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it would be better to test Windows only in the scheduled workflow. Testing it with every single change isn’t crucial and overall it will slow down our CI and make it harder to maintain.

.github/workflows/ci.yml Show resolved Hide resolved
@ddoktorski
Copy link
Contributor

Can we create an issue to investigate whether the cache action functions correctly, considering that the first CI run on a branch takes significantly longer than subsequent runs, and on Windows it is much longer than on Linux?

Example:
https://github.com/foundry-rs/starknet-foundry/actions/runs/12178894598/job/33969862907 <- first run does not find any cache
https://github.com/foundry-rs/starknet-foundry/actions/runs/12179972960/job/33973292419

@cptartur
Copy link
Member Author

Can we create an issue to investigate whether the cache action functions correctly, considering that the first CI run on a branch takes significantly longer than subsequent runs, and on Windows it is much longer than on Linux?

Example: https://github.com/foundry-rs/starknet-foundry/actions/runs/12178894598/job/33969862907 <- first run does not find any cache https://github.com/foundry-rs/starknet-foundry/actions/runs/12179972960/job/33973292419

@ddoktorski I'd just merge this and we'll see if te build times are problematic. And if so, we can disable these checks at any time.

@cptartur cptartur enabled auto-merge January 10, 2025 10:35
@cptartur cptartur added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit 7ebb054 Jan 10, 2025
38 checks passed
@cptartur cptartur deleted the 2716-run-tests-on-windows branch January 10, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run scheduled tests on windows machine
4 participants