Test for multiple writes/reads to the same storage slot

[beeguy74]

Closes #1559

Introduced changes

I modified locally :
storage_view field to map only StorageKey to felt

Screenshot of modified `crates/runtime/src/starknet/state.rs`

And created two test cases which ensure that writes to the storage across multiple contracts with same ClassHash and storage key is not possible inside crates/cheatnet/tests/cheatcodes/multiple_writes_same_storage.rs:

• same_storage_access_call_contract - Verifies that the two deployed contracts with same class_hash have different addresses and demonstrates modification and access to storage variable balance with call_contract method
• same_storage_access_store - does same routine but uses custom implementations for storage operations store and load instead of call_contract to access to storage

Checklist

• Linked relevant issue
• Updated relevant documentation
• Added relevant tests
• Performed self-review of the code
• Added changes to CHANGELOG.md

[franciszekjob]

Hi @beeguy74 👋,
let me if you're ready for review or need any assistance 😄

[beeguy74]

hi @franciszekjob ! I think i finished here. But I'm not sure it's necessary to change the documentation and changelog. Thank you in advance!

[franciszekjob]

Overall looks good 😄 , please see my nits.

[kkawula]

Please, show that these tests fail in the modified state

[beeguy74]

Hi @kkawula! As far the tests pass in both states: modified or not

[beeguy74]

So, guys. You want me to achieve a test failing?

[franciszekjob]

Hi @beeguy74 , let me check why these tests don't fail. Will update you.

[beeguy74]

It would help me a lot if you gave me another assignment, sir, while I'm blocked here. For example, I applied for another test issue. Can you assign me please?

[franciszekjob]

@beeguy74 in fact, the repro steps in issue description were a bit misleading. The tests should pass in both cases (so it's ok as it is now), apologies for little inconvenience.

[franciszekjob]

Please fix formatting 🙏

[beeguy74]

formatted

[beeguy74]

Can you merge it, please, to finish my ODboost contribution 🙏

[franciszekjob]

Can you merge it, please, to finish my ODboost contribution 🙏

Yes, added to merge queue :) Thank you for contribution 😄