Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ability scaling of adversaries monotonic #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make ability scaling of adversaries monotonic #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
476feae
make ability scaling of adversaries monotonic
danielrab Sep 27, 2024
4cfbcbe
Merge branch 'foundryvtt:master' into adversary-scaling
danielrab Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 19 additions & 34 deletions module/models/adversary.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,45 +132,30 @@ export default class CrucibleAdversary extends CrucibleActorType {
// Compute Archetype scaling weights
const weights = {};
let wTotal = 0;
const maxA = this.advancement.threatLevel <= 0 ? Math.max(...Object.values(archetype.abilities)) : undefined;
for ( const k in SYSTEM.ABILITIES ) {
const w = this.advancement.threatLevel > 0 ? archetype.abilities[k] : (maxA + 1 - archetype.abilities[k]);
const w = archetype.abilities[k];
weights[k] = Math.pow(w, 2);
wTotal += weights[k];
}

// Pass 1: Unconstrained Increases
let spent = 0;
for ( const k in SYSTEM.ABILITIES ) {
weights[k] /= wTotal;
const a = this.abilities[k];
a.desired = a.base + (toSpend * weights[k]);
let d = Math.round(Math.abs(toSpend) * weights[k]) * Math.sign(toSpend);
a.increases = Math.clamp(d, 1 - a.value, 18 - a.value);
a.value = a.base + a.increases;
spent += a.increases;
}
if ( spent === toSpend ) return;

// Pass 2: Iterative Assignment
const delta = Math.sign(toSpend - spent);
const order = [];
for ( const k in SYSTEM.ABILITIES ) {
const a = this.abilities[k];
const capped = delta > 0 ? a.value === 18 : a.value === 1;
if ( !capped ) order.push([k, a.desired, a.value]);
}
while ( spent !== toSpend ) {
if ( !order.length ) break; // No uncapped abilities remaining
if ( delta > 0 ) order.sort((a, b) => (b[1] - b[2]) - (a[1] - a[2])) // Increase farthest below desired value
else order.sort((a, b) => (a[1] - a[2]) - (b[1] - b[2])); // Reduce farthest above desired value
const target = order[0];
const a = this.abilities[target[0]];
a.increases += delta;
target[2] = a.value += delta;
const capped = delta > 0 ? a.value === 18 : a.value === 1;
if ( capped ) order.shift();
spent += delta;
const delta = Math.sign(toSpend);

for (let i = 0; i < Math.abs(toSpend); i++) {
let mostDivergingWeightedScore = Infinity * delta;
let mostDivergingAbility;
for ( const ability in SYSTEM.ABILITIES ) {
const score = this.abilities[ability].value;
const weightedScore = score / weights[ability];
if (
(toSpend > 0 && weightedScore < mostDivergingWeightedScore && score < 18)
|| (toSpend < 0 && weightedScore > mostDivergingWeightedScore && score > 1)
) {
mostDivergingWeightedScore = weightedScore;
mostDivergingAbility = ability;
}
}
this.abilities[mostDivergingAbility].increases += delta;
this.abilities[mostDivergingAbility].value += delta;
}
}

Expand Down