Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemaEncoding to mcap-play channel registration #591

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

defunctzombie
Copy link
Contributor

This conveys the schema encoding to the client allowing it to use the correct parser to handle the schema.

This conveys the schema encoding to the client allowing it to use the correct parser to handle the schema.
@defunctzombie defunctzombie enabled auto-merge (squash) November 15, 2023 01:05
@jtbandes
Copy link
Member

Adding for context that I believe this is specifically necessary for IDL messages because the cdr message encoding can be used with either ros2msg or ros2idl schema encoding. If the client does not know which one to use it is forced to assume one based on cdr and it chooses ros2msg by default.

@defunctzombie defunctzombie merged commit cada881 into main Nov 15, 2023
11 checks passed
@defunctzombie defunctzombie deleted the roman/mcap-play-schema-encoding branch November 15, 2023 01:20
@jtbandes
Copy link
Member

We should also bump the examples package version and push the appropriate tag so it gets released to NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants