Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use persist-credentials: false in GHAs #773

Merged
merged 2 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
sudo --login -u postgres psql -c "ALTER USER postgres WITH PASSWORD 'postgres';"

- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install poetry
run: pipx install poetry==2.0.0
Expand Down Expand Up @@ -64,6 +66,8 @@ jobs:
needs: tests
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- run: pipx install poetry==2.0.0

Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/documentation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Deploy docs
uses: mhausenblas/mkdocs-deploy-gh-pages@master
Expand All @@ -29,6 +31,9 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false


- uses: actions/setup-python@v5
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pip_install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
steps:

- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/poetry_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ jobs:
runs-on: ubuntu-22.04
steps:

- name: Checkout repository
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: "Set up Python 3.10"
uses: actions/setup-python@v5
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/poetry_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- name: Install poetry
run: pipx install poetry==2.0.0
with:
persist-credentials: false
- run: pipx install poetry==2.0.0

- uses: actions/setup-python@v3
with:
python-version: "3.10"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
timeout-minutes: 3
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: "3.10"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/publish_pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ jobs:
if: ${{ env.CURRENT_PYPI_TOKEN == '' }}
run: echo "Secret PYPI_TOKEN is not defined." && exit 1

- name: Checkout repository
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: "Set up Python 3.10"
uses: actions/setup-python@v5
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* Remove `exclude` field, and move `packages` field to `tool.poetry` section, in pyproject.toml (\#771).
* Testing:
* Improve configuration for coverage GitHub Action step (\#772).
* Add `persist-credentials: false` to all `actions/checkout@v4` GitHub Action steps (\#773).

# 2.6.1

Expand Down
Loading