Skip to content

Commit

Permalink
Merge pull request #2175 from fractal-analytics-platform/2152-fix-use…
Browse files Browse the repository at this point in the history
…-of-coverage-in-gha

Fix use of coverage in gha
  • Loading branch information
tcompa authored Jan 9, 2025
2 parents 4cc4f72 + cc93371 commit 5dfaf4a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,15 @@ jobs:
steps:
- uses: actions/checkout@v4

- run: pipx install poetry==2.0.0

- uses: actions/setup-python@v5
with:
python-version: "3.10"
cache: "poetry"

- name: Install dependencies
run: python -m pip install --upgrade coverage[toml]
run: poetry install --only dev

- name: Download data
uses: actions/download-artifact@v4
Expand All @@ -155,7 +158,7 @@ jobs:
# We added this step to replace the variable `MERGE_COVERAGE_FILES: true`
# in the next step, which had started to raise errors
# (https://github.com/fractal-analytics-platform/fractal-server/pull/1725).
run: coverage combine coverage-data-*
run: poetry run coverage combine coverage-data-*

- name: Add coverage comment to Pull Requests
id: coverage_comment
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* App:
* Add missing space in "To" field for email settings (\#2173).
* Testing:
* Improve configuration for coverage GitHub Action step (\#2175).

# 2.10.4

Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ push = true
branch = true
parallel = true
relative_files = true
omit = ["tests/*", "benchmarks/*", "fractal_server/json_schemas/*"]
omit = ["tests/*", "benchmarks/*", "fractal_server/json_schemas/*", "*/.venv/*"]

[tool.coverage.report]
omit = ["tests/*", "benchmarks/*", "fractal_server/json_schemas/*", "*/.venv/*"]

[tool.mypy.overrides]
module = ["devtools", "uvicorn", "pytest", "asgi_lifespan", "asyncpg"]
Expand Down

0 comments on commit 5dfaf4a

Please sign in to comment.