Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to poetry v2 #2165

Merged
merged 17 commits into from
Jan 7, 2025
Merged

Switch to poetry v2 #2165

merged 17 commits into from
Jan 7, 2025

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jan 7, 2025

Closes #2164

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Copy link

github-actions bot commented Jan 7, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 1.0 0.9 1.11 0.0 0.0
power 0.9 0.8 1.12 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.7 9.3 1.04 0.6 0.6
power 406.7 408.6 1.00 366.2 366.2
dataset 149.7 154.1 0.97 134.0 134.0
project 44.0 42.7 1.03 47.2 47.2
job 29.9 28.7 1.04 32.4 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 6.0 1.10 2.2 2.2
power 139.2 136.5 1.02 652.2 652.2
dataset 143.2 143.7 1.00 905.2 905.2
project 46.3 46.4 1.00 283.8 283.8
job 39.8 40.2 0.99 224.9 224.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.1 7.7 0.92 0.1 0.1
power 7.4 7.2 1.03 0.1 0.1
dataset 7.4 6.9 1.07 0.1 0.1
project 9.1 9.2 0.99 2.3 2.3
job 7.3 6.8 1.07 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.9 5.7 1.04 0.8 0.8
power 6.1 5.5 1.11 0.8 0.8
dataset 6.3 5.9 1.07 0.8 0.8
project 5.9 5.6 1.05 0.8 0.8
job 5.9 5.6 1.05 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.8 7.2 0.94 1.6 1.6
power 7.1 6.7 1.06 1.6 1.6
dataset 6.8 6.7 1.01 1.6 1.6
project 7.2 6.7 1.07 1.6 1.6
job 7.2 6.7 1.07 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.5 11.1 1.04 0.8 0.8
power 24.8 24.9 1.00 29.1 29.1
dataset 18.4 18.3 1.01 16.7 16.7
project 22.1 21.4 1.03 21.0 21.0
job 10.8 10.4 1.04 0.8 0.8

POST /api/v2/project/3/dataset/406/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 148.0 146.8 1.01 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.6 4.9 0.94 0.2 0.2
power 4.4 4.8 0.92 0.2 0.2
dataset 4.4 4.7 0.94 0.2 0.2
project 4.3 4.4 0.98 0.2 0.2
job 4.3 4.4 0.98 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.8 273.6 1.00 0.2 0.2

Copy link

github-actions bot commented Jan 7, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/app/runner/v2/_local_experimental
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa marked this pull request as ready for review January 7, 2025 13:58
@tcompa tcompa merged commit 6c1b55b into main Jan 7, 2025
@tcompa tcompa deleted the poetry-v2 branch January 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to poetry v2
1 participant