Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to startup logs #2228

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jan 28, 2025

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@tcompa tcompa linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 28, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.7 1.14 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.4 9.5 0.99 0.6 0.6
power 358.9 364.9 0.98 345.4 345.4
dataset 127.2 135.6 0.94 123.2 123.2
project 37.2 38.4 0.97 43.9 43.9
job 24.1 25.9 0.93 29.7 29.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 6.5 0.95 2.2 2.2
power 123.4 124.3 0.99 662.6 662.6
dataset 127.5 129.2 0.99 916.0 916.0
project 41.8 43.5 0.96 287.2 287.2
job 37.5 40.0 0.94 227.6 227.6

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.6 7.4 1.03 0.1 0.1
power 7.4 7.0 1.06 0.1 0.1
dataset 7.4 7.1 1.04 0.1 0.1
project 9.2 8.7 1.06 2.3 2.3
job 7.2 6.9 1.04 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 6.1 1.00 0.8 0.8
power 5.8 6.1 0.95 0.8 0.8
dataset 5.9 5.9 1.00 0.8 0.8
project 6.2 6.2 1.00 0.8 0.8
job 5.9 5.9 1.00 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.2 7.2 1.00 1.6 1.6
power 6.7 6.7 1.00 1.6 1.6
dataset 6.6 6.8 0.97 1.6 1.6
project 6.6 6.9 0.96 1.6 1.6
job 6.6 6.8 0.97 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 10.9 0.95 0.8 0.8
power 22.4 23.1 0.97 28.0 28.0
dataset 18.1 18.5 0.98 16.2 16.2
project 20.7 20.7 1.00 20.4 20.4
job 11.2 10.4 1.08 0.8 0.8

POST /api/v2/project/3/dataset/412/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 135.8 142.5 0.95 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 4.8 4.9 0.98 0.2 0.2
power 4.6 4.6 1.00 0.2 0.2
dataset 4.5 4.5 1.00 0.2 0.2
project 4.4 4.5 0.98 0.2 0.2
job 4.3 4.5 0.96 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.3 274.8 0.99 0.2 0.2

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  main.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log server version upon startup
1 participant