Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error when there is task-status list #546

Closed
tcompa opened this issue Sep 4, 2024 · 2 comments · Fixed by #548
Closed

Show an error when there is task-status list #546

tcompa opened this issue Sep 4, 2024 · 2 comments · Fixed by #548

Comments

@tcompa
Copy link
Collaborator

tcompa commented Sep 4, 2024

We observed this today, when submission failed before starting execution of tasks (due to external factors, namely SSH connection being down).
In this case, we cannot show any "failed" status next to a task, but we could show an error somewhere else in the page.

@tcompa
Copy link
Collaborator Author

tcompa commented Sep 5, 2024

The specific case that triggered this issue was fixed in fractal-server 2.3.11 (see fractal-analytics-platform/fractal-server#1728), but this remains valid for other cases where something fails before the first task started.

@zonia3000
Copy link
Collaborator

In #548 I've added a unit test for this case that is not easily reproducible in e2e tests.

I've manually tested it adding a raise Exception('foo') here: https://github.com/fractal-analytics-platform/fractal-server/blob/2e465134b65c2723e95c55bcfe7f7c4ade872f5c/fractal_server/app/runner/v2/__init__.py#L207

The result is the following:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants