Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment with fractal-server 2.7 #583

Merged
merged 16 commits into from
Oct 11, 2024
Merged

Alignment with fractal-server 2.7 #583

merged 16 commits into from
Oct 11, 2024

Conversation

zonia3000
Copy link
Collaborator

@zonia3000 zonia3000 commented Oct 10, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Closes #575
Closes #576
Closes #577
Closes #578
Closes #588
Closes #587
Closes #586

@tcompa
Copy link
Collaborator

tcompa commented Oct 10, 2024

A first glitch:
image

Tasks do exist (I see a lot of them in http://localhost:5173/v2/tasks), but something shows here that they do not exit.

@tcompa
Copy link
Collaborator

tcompa commented Oct 10, 2024

Previous issue was due to version 0.7.10.dev4+g4c8ebe3 of a task

@zonia3000 zonia3000 merged commit 3151f5e into main Oct 11, 2024
7 checks passed
@zonia3000 zonia3000 deleted the align-server-2.7 branch October 11, 2024 10:31
@zonia3000
Copy link
Collaborator Author

Starting from this PR I added a job step to the CI to save the test-results folder generated by Playwright. The folder contains the screenshots of failed tests, so it can be useful to check cases when the tests pass locally but fails on the CI:

image

Notice that the last job was successful but the folder is not empty, indicating that there are some flaky tests (failed at first attempt, then passed on retry).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment