Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review GitHub Actions with zizmor 1.0.1 #687

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Review GitHub Actions with zizmor 1.0.1 #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0af6244
Add a bunch of `persist-credentials: false` to GitHub actions
tcompa Jan 9, 2025
222e68d
Do not opt-in for npm cache within `github_release.yaml`
tcompa Jan 9, 2025
42c9bba
Replace template expansion with env variable in `github_release.yaml`
tcompa Jan 9, 2025
ad1c468
CHANGELOG [skip ci]
tcompa Jan 9, 2025
10cc885
Added missing persist-credentials option
zonia3000 Jan 9, 2025
bf5e9dc
Added quotes on release tar file name
zonia3000 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/documentation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- uses: actions/setup-python@v4
with:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/end_to_end_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ jobs:
- 5556:5556

steps:
- name: Check out repo
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up node
uses: actions/setup-node@v4
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/github_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
node-version: ['18', '20']

steps:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: npm

- name: Install dependencies
run: npm install
Expand All @@ -40,9 +40,13 @@ jobs:
run: tar -xzf fractal-web-*.tgz

- name: Repack the package removing parent folder
run: tar -C package -czf node-${{ matrix.node-version }}-fractal-web-${{ github.ref_name }}.tar.gz build package.json node_modules LICENSE
env:
GITHUB_REF_NAME: ${{ github.ref_name }}
run: tar -C package -czf "node-${{ matrix.node-version }}-fractal-web-${GITHUB_REF_NAME}.tar.gz" build package.json node_modules LICENSE

- name: Release
uses: softprops/action-gh-release@v2
env:
GITHUB_REF_NAME: ${{ github.ref_name }}
with:
files: node-${{ matrix.node-version }}-fractal-web-${{ github.ref_name }}.tar.gz
files: node-${{ matrix.node-version }}-fractal-web-${GITHUB_REF_NAME}.tar.gz
5 changes: 3 additions & 2 deletions .github/workflows/lint_and_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ jobs:
node-version: ['18', '20']

steps:
- name: Check out repo
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up node
uses: actions/setup-node@v4
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ jobs:
node-version: ['18', '20']

steps:
- name: Check out repo
uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up node
uses: actions/setup-node@v4
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
*Note: Numbers like (\#123) point to closed Pull Requests on the fractal-web repository.*

# Unreleased
* Fixed findings based on `zizmor 1.0.1` audit (\#687).

# 1.14.0

* Removed legacy version support (\#684);
Expand Down
Loading