Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout after 10 seconds to speed up the test on slow routes #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

linearray
Copy link

This should also provide some pain relief for #8

@linearray
Copy link
Author

I should add that this does of course still calculate the transfer speed within those ten seconds. It just doesn't necessarily download the whole file, which can take minutes and seems unnecessary.

@frankthetank7254
Copy link
Owner

i think 10 seconds may be way too low for many users. I know for some people with slower connections, many of the routes are slow, and they need the script to run for quite a while to get good results. (for those people, smaller test files may be a better answer, but I can only use what I'm given :)

thanks for your idea!

@toxicantidote
Copy link

I'd support this idea using the max-time option for curl. Maybe set it to something a bit longer (e..g 30 seconds) or make it configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants