Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Huge overhaul and bug fixes #7

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Huge overhaul and bug fixes #7

merged 2 commits into from
Feb 3, 2024

Conversation

ipstolen
Copy link
Contributor

@ipstolen ipstolen commented Feb 2, 2024

changed the number 4 to 3.

@Krylez Krylez linked an issue Feb 3, 2024 that may be closed by this pull request
@@ -434,11 +434,11 @@ public void clickMatchPhase(View v){

public void clickTarmac(View v){
if(isAuto){
zAutoTarmac = (zAutoTarmac + 1)%4;
zAutoTarmac = (zAutoTarmac + 1)%3;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

another option is to use the size of the array so that it never crashes:

            zAutoTarmac = (zAutoTarmac + 1)%climbDisplayText.length;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very smart

@Krylez
Copy link

Krylez commented Feb 3, 2024

👍

@ipstolen ipstolen merged commit 753f15e into main Feb 3, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in MainActivity
2 participants