Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a bunch of typeclass instances to EnvT #6

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

OlaoluwaM
Copy link
Contributor

@OlaoluwaM OlaoluwaM commented Nov 22, 2024

Also upgraded the stack LTS and nightly resolver versions so CI can pass

@OlaoluwaM OlaoluwaM requested a review from pbrisbin November 22, 2024 14:18
@OlaoluwaM OlaoluwaM self-assigned this Nov 22, 2024
pbrisbin
pbrisbin previously approved these changes Nov 22, 2024
library/Control/Monad/AWS/EnvT.hs Show resolved Hide resolved
@OlaoluwaM OlaoluwaM changed the title feat: Add MonadError instance to EnvT feat: Add a bunch of typeclass instances to EnvT Dec 3, 2024
@OlaoluwaM OlaoluwaM requested a review from pbrisbin December 3, 2024 15:45
pbrisbin
pbrisbin previously approved these changes Dec 3, 2024
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocking on replacing Blammo with monad-logger as the dependency for the logger classes.

package.yaml Outdated Show resolved Hide resolved
stack-nightly.yaml Outdated Show resolved Hide resolved
This reverts commit 26622b9.

Looks like the stack-nightly.yaml is meant more as a placeholder to get
CI to try to build this package with `--resolver nightly`. This tends to
fail, but that's okay.

Moreover, since this file is meant more as a placeholder of sorts, we
don't need to include more info than what's necessary for this to be
considered a valid `stack.yaml` file. Thus, simply upgrading the
resolver version to the latest nightly version at the time of upgrading
will often suffice
pbrisbin
pbrisbin previously approved these changes Dec 3, 2024
stack-nightly.yaml.lock Outdated Show resolved Hide resolved
@OlaoluwaM OlaoluwaM merged commit 6062c56 into freckle:main Dec 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants