generated from freckle/haskell-library-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a bunch of typeclass instances to EnvT #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
previously approved these changes
Nov 22, 2024
pbrisbin
reviewed
Nov 22, 2024
OlaoluwaM
changed the title
feat: Add MonadError instance to EnvT
feat: Add a bunch of typeclass instances to EnvT
Dec 3, 2024
pbrisbin
previously approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only blocking on replacing Blammo
with monad-logger
as the dependency for the logger classes.
This reverts commit 26622b9. Looks like the stack-nightly.yaml is meant more as a placeholder to get CI to try to build this package with `--resolver nightly`. This tends to fail, but that's okay. Moreover, since this file is meant more as a placeholder of sorts, we don't need to include more info than what's necessary for this to be considered a valid `stack.yaml` file. Thus, simply upgrading the resolver version to the latest nightly version at the time of upgrading will often suffice
pbrisbin
previously approved these changes
Dec 3, 2024
pbrisbin
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgraded the stack LTS and nightly resolver versions so CI can pass