Break up stack-arguments, prep v5 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Closed
The `stack-arguments` option preceding this was too limited. It could be
used for global arguments to `stack` as well as arguments to `stack
build`, this made it impossible to use the input consistently across all
`stack` commands we happen to invoke.
The new interface separates:
- `stack-arguments` for globals arguments, used in all invocations from
- `stack-build-arguments` for all `stack build` invocations from
- `stack-build-arguments-{step}` for _specific_ `stack build` invocations and, finally
- `stack-{subcommand}-arguments` for other invocations
- Bump version of actions/cache used - Bump version of actions/checkout used - Trim trailing whitespace
We suspect including this is causing some churn in the hash when sources haven't, in fact, changed.
- Describe notable changes in v4 and v5 - Move linter removal notes up to changes subsections - Tweak generate-matrix README section - Generate Inputs/Outputs sections To do so: ```console npm instlal npm run readme ``` - Polish `action.yml` - Improve descriptions - Don't add `required: true` when there is a default - Use `required: false` instead of `default: ""` These should all help the generated README look better.
|
OK, I think this is done and history polished. |
|
Here is a PR (private) where I'm testing this branch: https://github.com/freckle/megarepo/pull/32653 |
|
Would you like to let other people comment on this PR? I can share a link to this PR on a Telegram group (~1.6K Haskellers). |
deemp
reviewed
Feb 1, 2024
stackptr
reviewed
Feb 1, 2024
stackptr
reviewed
Feb 1, 2024
It can't hurt. Though I would make it clear the action implementation itself is a mess of shell code, it's just used for Haskell, so it might be more of a review of the interface than the diff, you know? |
|
Seems like there are no suggestions from members of that group. |
|
Thanks! Sorry this week go away from us, I'll try to merge early last week. |
stackptr
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement subcommand-specific options
66873d2
The
stack-argumentsoption preceding this was too limited. It could beused for global arguments to
stackas well as arguments tostack build, this made it impossible to use the input consistently across allstackcommands we happen to invoke.The new interface separates:
stack-argumentsfor globals arguments, used in all invocations fromstack-build-argumentsfor allstack buildinvocations fromstack-build-arguments-{step}for specificstack buildinvocations and, finallystack-{subcommand}-argumentsfor other invocationsFix workflows
e31a26f
Use correct name for macOS in comment
81b64a1
Exclude .git in source-hash
c974d19
We suspect including this is causing some churn in the hash when sources
haven't, in fact, changed.
Rewrite README
fafd74f
Rendered
Describe notable changes in v4 and v5
Move linter removal notes up to changes subsections
Tweak generate-matrix README section
Generate Inputs/Outputs sections
To do so:
Polish
action.ymlrequired: truewhen there is a defaultrequired: falseinstead ofdefault: ""These should all help the generated README look better.