Deprecate stack-yaml input #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
commented
Feb 21, 2024
See https://stackoverflow.com/a/60905543 This brought the test suite down from ~6s to ~1s on my machine.
Users can either set `STACK_YAML` or `stack-arguments` to add `--stack-yaml`, which each come with their own trade-offs depending on the nature of the Job in which this action is used. Either way, a dedicated input is not necessary or useful. Before this commit, users who set `STACK_YAML` _and_ used `inputs.stack-yaml` could get themselves in trouble if they weren't careful. I decided to keep the input for now, to avoid needing a major version bump but: - Documentation says it's deprecated - It triggers a warning - It results in naively pushing the value into `stack-arguments`, which is what the behavior was before, but might misbehave if the user is also setting `env.STACK_YAML` or already has `--stack-yaml` in `stack-arguments`, which was also the behavior before, I guess
pbrisbin
force-pushed
the
pb/rm-stack-yaml-2
branch
from
f50c928 to
cbc3c3b
Compare
stackptr
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set isolatedModules: true
1a48f85
See https://stackoverflow.com/a/60905543
This brought the test suite down from ~6s to ~1s on my machine.
Commit forgotten README update
add9aad
Remove stack-yaml input
7d8662b
Users can either set
STACK_YAMLorstack-argumentsto add--stack-yaml, which each come with their own trade-offs depending onthe nature of the Job in which this action is used. Either way, a
dedicated input is not necessary or useful.
Before this commit, users who set
STACK_YAMLand usedinputs.stack-yamlcould get themselves in trouble if they weren'tcareful.
I decided to keep the input for now, to avoid needing a major version
bump but:
stack-arguments, whichis what the behavior was before, but might misbehave if the user is
also setting
env.STACK_YAMLor already has--stack-yamlinstack-arguments, which was also the behavior before, I guess