Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #57 #69

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Resolve #57 #69

merged 2 commits into from
Mar 28, 2024

Conversation

deemp
Copy link
Contributor

@deemp deemp commented Mar 24, 2024

Closes #57

I followed a note from the actions/cache (link).

Seems to work fine in my project.

Before: 2m 38s

After: 35s

Feel free to remove ba9f365 and build on your own.

Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great find.

I wonder if we should update our typescript template repository to always do this. I struggle to see any downside.

@pbrisbin pbrisbin merged commit 747f7b4 into freckle:main Mar 28, 2024
17 of 18 checks passed
@pbrisbin
Copy link
Member

Pushed as v5.1.1 and @v5 updated.

@pbrisbin
Copy link
Member

pbrisbin commented Mar 28, 2024

I had to revert this as v5.1.2. We found that the build failing does not fail the step anymore.

Notice here the build failed, but it proceeded to upload the artifacts. Since the failing step did not set the local-bin output, the path: / option to upload-artifact generated a confusing error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexplainable delay after "Set outputs"
2 participants