-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in DNS #326
Typo in DNS #326
Conversation
@ZePotente could you please fix up your git commit email address to be something valid, and not a |
Is the commit mail issue solved now or do I have to amend the commit? |
an easy way to check is to append .patch up the pull request URLs: https://github.com/freebsd/freebsd-doc/pull/326.patch that should show you what will get committed. |
Thanks @igalic @ZePotente Thanks for your contribution. To properly register your contribution, we will need your e-mail and name. This is what we are receiving at this moment:
Alternatively, if you prefer not to share your email, that's perfectly fine. We can simply add a line like this in the commit message:
|
I'm sorry for the inconvenience, I don't really understand where these things are done in the github web UI and I don't really want to make fixing typos more trouble than it's worth. I just saw a couple of typos and wanted them gone. |
these are not things that can be fixed in the UI, without much effort. on the CLI you'd have to pull the branch down, edit the author, and push it back:
|
understanded -> understood
understanded -> understood Reviewed by: Pau Amma <[email protected]>, dbaio Pull Request: #326
Committed on ae59c39 |
understanded -> understood