Prepare for sanitizer runs to fail hard during CI #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-trivial leaks or leaks where the fix is considered major work, document and suppress them. Intention is to get to a suppression list as TODO/FIXME and 0 leaks reported so we can turn on error triggering in newly introduced leaks.
|
Rebased to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip known not to work elfparsing on Linux/Ubuntu.
Instead of 200 failing/broken tests in ASAN/LSAN runs, prepare a list of ~20 exclusions which cause memory leaks.
Fix along the way another dozen of leaks.
The list of exclusions is considered to be better, as you can decide to work on one at a time. Clearing out the list. Note that some of the exclusions cover heavily used core code paths.
Having no errors in ASAN/LSAN runs enables to trigger errors when NEW leaks are introduced into the codebase, hence stopping the rot.
Note that atf-0.22 pretty much broke kyua/atf on MacOS, the MacOS CI runs take infinite time. Ubuntu is still fine (on 0.21).