Authorization bypass with Impersonate button ONLY for localdev #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you specify http://localhost:5000/authorization?athlete_id=NNNN you can now authorize as that athlete. TODO: * Retrieve athlete from database, only use those, get rid of mock class * Consider adding UI support for just selecting the athlete to auth as - maybe a special link off the People page that only shows in the localdev environment for each person. Or a big old "Impersonate" button (also only showing on localdev) on that person's page. That would be the most convenient. * Consider adding a nonce that would print in the logs only for this session for the localhost authorization URL. That might prevent some classes of attacks.
obscurerichard
added
enhancement
help wanted
…reezingsaddles/freezing-web into feature-localdev-authentication-bypass
obscurerichard
changed the title
Also fix up menu headings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you view the URL http://localhost:5000/authorization?athlete_id=NNNN you can now fake authorizing as that athlete only in the localdev environment in order to better debug the individual user pages.
localdevenvironment