Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FawltyDeps linter #406

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Add FawltyDeps linter #406

merged 6 commits into from
Jan 15, 2025

Conversation

obscurerichard
Copy link
Member

Highlight mystery surrouding custom_mapping

Highlight mystery surrouding custom_mapping
@obscurerichard obscurerichard added this to the 2025 - Competition End milestone Jan 14, 2025
@obscurerichard obscurerichard added enhancement dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 14, 2025
Otherwise fawltydeps finds more problems than expected:

```

These imports appear to be undeclared dependencies:
- 'dateutil'
- 'instagram'

These dependencies appear to be unused (i.e. not imported):
- 'freezing-model'
- 'python-dateutil'
- 'python-instagram'

For a more verbose report re-run with the `--detailed` option.
```
Thanks @jherland for the hint that the namespaces for freezing.* are
[PEP 420 – Implicit Namespace Packages | peps.python.org](https://peps.python.org/pep-0420/)

See also [What's a Python Namespace Package, and What's It For? – Real Python](https://moduscreate.slack.com/archives/C04AAQP8C85/p1736959685922509?thread_ts=1736870165.381949&cid=C04AAQP8C85)
@obscurerichard obscurerichard merged commit d3043f8 into main Jan 15, 2025
7 checks passed
@obscurerichard obscurerichard deleted the add-fawltydeps-lint branch January 15, 2025 17:27
@obscurerichard
Copy link
Member Author

For now I just had to exclude freezing-model as FawltyDeps is not yet capable of handling PEP 420 implicit namespace packages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant