Remove usages deprecated by sqlalchemy 2.0 from freezing-web #429
+287
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinorg
force-pushed
the
sqlalchemy-deprecation
branch
from
1552ee4 to
a1a1321
Compare
merlinorg
changed the title
merlinorg
force-pushed
the
sqlalchemy-deprecation
branch
from
a1a1321 to
6ec8567
Compare
merlinorg
force-pushed
the
sqlalchemy-deprecation
branch
3 times, most recently
from
6e718e4 to
8a8955e
Compare
merlinorg
commented
Jan 22, 2025
| @@ -20,19 +20,21 @@ <h1> | |||
| </p> | |||
| <ol> | |||
| {% for indiv_row in indiv_rows[:10] %} | |||
| <li class="bigly {{ indiv_row['athlete_id'] | myself }}"> | |||
There was a problem hiding this comment.
Were I more diligent I would move all of this sqlalchemy code into python and hand named tuples into the template for rendering, but such a change is beyond my current inclination.
merlinorg
force-pushed
the
sqlalchemy-deprecation
branch
from
8a8955e to
4d30990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #405. This passes the wget-spider.sh test.