Run Spago from a nested directory other than workspace root #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
commented
Dec 19, 2024
Comment on lines
+967
to
+970
| FS.mkdirp $ rootPath </> Paths.localCachePath | ||
| FS.mkdirp $ rootPath </> Paths.localCachePackagesPath | ||
| logDebug $ "Workspace root path: " <> Path.quote rootPath | ||
| logDebug $ "Local cache: " <> Paths.localCachePath |
There was a problem hiding this comment.
This is only semi-related to the change. I found that, before this change, Spago would always create a ./.spago directory as soon as it's launched, even if it's only asked to registry search. I moved this from mkRegistryEnv to mkFetchEnv, which seems to be logically always "in a workspace".
fsoikin
commented
Dec 19, 2024
| rightOrDieWith :: ∀ a b m err x. MonadEffect m => MonadAsk (LogEnv b) m => Loggable a => Either err x -> (err -> a) -> m x | ||
| rightOrDieWith value toMsg = case value of | ||
| rightOrDieWith :: ∀ a b m err x. MonadEffect m => MonadAsk (LogEnv b) m => Loggable a => (err -> a) -> Either err x -> m x | ||
| rightOrDieWith toMsg value = case value of |
There was a problem hiding this comment.
This function wasn't actually used anywhere (until now), so I swapped the parameters to allow it to be called with postfix application like foo >>= rightOrDieWith \err -> die $ "Error: " <> err
fsoikin
commented
Dec 19, 2024
| Right a -> | ||
| pure a | ||
| Left err -> | ||
| die $ toMsg err | ||
|
|
||
| rightOrDieWith' :: ∀ a b m err x. MonadEffect m => MonadAsk (LogEnv b) m => Loggable a => Either err x -> (err -> Array a) -> m x | ||
| rightOrDieWith' value toMsg = case value of |
There was a problem hiding this comment.
This was also not used anywhere, and also is redundant, since there is an instance Loggable a => Loggable (Array a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is built on top of purescript#1296, so for now it's targeted at my own fork. Once purescript#1296 is merged, I will open a proper PR to the original repo.
@f-f
Description of the change
Fixes purescript#1237
Allowing Spago to be launched from a directory nested within the workspace.
spago.yamlcontaining a workspace.spago.yamlfiles back down the tree and loads those that it hasn't loaded while walking up.spago.yml(wrong extension) files.ymlfiles found along the way, if any, suggesting that they may have the wrong extension.Checklist:
[ ] Added some example of the new feature to theREADME