Move to .NET Standard #131
Conversation
cartermp
commented
Apr 21, 2020
cartermp
commented
- Update all build dependencies to be .NET Standard 2.0 only
- Move to explicit TPDTC and TPRTC components
- Adjust build to generate the right stuff for development
- Get tests working (depends on some local state?)
- Adjust CI
- Move to .NET 5 preview SDK and then adjust all scripts to use preview FSI/packagereference
| <Target Name="MoveDesignTimeAssembliesToTypeProviderFolder" AfterTargets="AfterBuild"> | ||
| <CreateItem Include="..\FSharp.Azure.StorageTypeProvider.DesignTime\bin\$(Configuration)\netstandard2.0\publish\*.dll;..\FSharp.Azure.StorageTypeProvider.DesignTime\bin\$(Configuration)\netstandard2.0\publish\*.pdb"> | ||
| <Output TaskParameter="Include" ItemName="DesignTimeBinaries" /> | ||
| </CreateItem> | ||
| <Copy SourceFiles="@(DesignTimeBinaries)" DestinationFolder="$(OutputPath)../typeproviders/fsharp41/netstandard2.0" /> |
There was a problem hiding this comment.
This one is key, a real pain in the ass, and also something I intend on shipping in the TPSDK so that we don't utilize an MSBuild hack that it currently suggests
| // do () |
|
I'm also bad at paket so the way I futzed with dependencies and the paket.template file is probably not ideal |
|
@cartermp The move to design time / runtime assemblies is something which I understand was always the "right" way to go, so that's great to see :-) I'm still getting the error with tests not building locally, but this feels like a step in the right direction. I have a branch, get-stuff-working, which was basically hacked together and was as far as I ever got - again, this was as far as I got (project building, but not the tests). How can I help move things forwards - what's the next step? And, would things be easier if we just targetted netcore rather than netstandard? |
|
@isaacabraham I think the next step is to see if some of the testing can be improved. At least on my machine, the tests attempt to build, but the type provider itself fails to initialize due to missing some emulation stuff for Azure Storage that I don't appear to have. It's unclear to me if the emulator is still the right tool to use for testing or not. Separately, properly testing all the F# scripts will, unfortunately, depend on .NET 5. So this will either have to wait until it releases in the fall, or this repo will need to build with a preview of .NET 5 until then. |
