Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #41 .
Instead of simply using a batch size of 100 we now check the maximum possible size of the entity type we are given and calculate the batch size from there by dividing the max batch size by the max size of an entity then using the min of that result and 100.
in order to calculate the max size of an entity I used the table here
I did have a concern that as I am measuring only the properties on a
DynamicTableEntity
that later elements in the array may have a different set of properties but, on reflection, I don't think this is possible. I think it's impossible because, as it is being called from inside theInsert
function, theDynamicTableEntity
will have just been mapped from the generated table entity?