-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
endStep stepUnits in subhourly wrf grib2 output #364
Conversation
(ref #363 ) |
@dcherian Do you have any suggestions on how to resolve this based on your work last week (very excited by the way!)? |
Have you asked over at ecCodes? I think this needs to be solved there. Can you link to a file that exhibits this problem? |
gs://high-resolution-rapid-refresh/hrrr.20230928/conus/hrrr.t00z.wrfsubhf01.grib2 |
@martindurant will you merge a PR that catches and logs exception till we can get this sorted? |
I will try upgrading to the latest eccodes and then file a bug if this is still an issue... |
Certainly. The HDF module already does this. |
xref ecmwf/cfgrib#335 |
Thank you for finding those - I don't see anything here that is likely to get fixed quickly here in eccodes - do you? |
No easily accessible channel to follow in eccodes as to when this will be resolved. |
Is there a good way to copy out a few messages from a larger grib2 file to make a test file? |
Absolutely, this is what kerchunk.grib._split_file does, e.g., as used in scan_grib:
|
Should be ready to go now? |
Something changed in numcodecs entrypoints? |
I am so confused - that can't be related to my changes right? |
Perhaps pin to numcodecs<=0.11, and we'll figure it out in a separate PR |
OK, done! |
Enable reading grib2 files with subhourly data from the WRF model such as
gs://high-resolution-rapid-refresh/hrrr.20230928/conus/hrrr.t00z.wrfsubhf01.grib2
The error: WrongStepUnitError(Wrong units for step (step must be integer))
Is now caught and logged. The bad coordinate attribute is dropped.