Disable special char (#) for hns

fsspec · Nov 11, 2024 · fcf105c · fcf105c
1 parent 26c0458
commit fcf105c
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 37 deletions.
diff --git a/.github/workflows/ci_hns.yml b/.github/workflows/ci_hns.yml
@@ -62,5 +62,6 @@ jobs:
         echo "TOSFS_LOGGING_LEVEL=${{ vars.TOSFS_LOGGING_LEVEL }}" >> $GITHUB_ENV
         echo "TOS_SDK_LOGGING_LEVEL=${{ vars.TOS_SDK_LOGGING_LEVEL }}" >> $GITHUB_ENV
         echo "TOS_BUCKET=${{ matrix.bucket-name }}" >> $GITHUB_ENV
+        echo "HNS_DISABLE_SPECIAL_CHAR_TESTS=${{ vars.HNS_DISABLE_SPECIAL_CHAR_TESTS }}" >> $GITHUB_ENV
     - name: Run tests
       run: make test
diff --git a/tosfs/tests/test_tosfs.py b/tosfs/tests/test_tosfs.py
@@ -427,43 +427,47 @@ def test_put(tosfs: TosFileSystem, bucket: str, temporary_workspace: str):
         ) as file:
             assert file.read() == "hello world"
 
-    with tempfile.TemporaryDirectory() as local_temp_dir:
-        dir_2 = f"{local_temp_dir}/生技??174号文/"
-        dir_3 = f"{local_temp_dir}/生技**174号文/"
-        dir_4 = f"{local_temp_dir}/生技_=+&^%#174号文/"
-        os.makedirs(dir_2)
-        os.makedirs(dir_3)
-        os.makedirs(dir_4)
-        with open(f"{dir_2}/test.txt", "w") as f:
-            f.write("hello world")
-        tosfs.put(
-            local_temp_dir,
-            f"{bucket}/{temporary_workspace}",
-            recursive=True,
-            disable_glob=True,
-        )
-        assert tosfs.exists(
-            f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
-            f"/生技??174号文/"
-        )
-        assert tosfs.exists(
-            f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
-            f"/生技??174号文/test.txt"
-        )
-        assert tosfs.exists(
-            f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
-            f"/生技**174号文/"
-        )
-        assert tosfs.exists(
-            f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
-            f"/生技_=+&^%#174号文/"
-        )
-        with tosfs.open(
-            f"{bucket}/{temporary_workspace}/"
-            f"{os.path.basename(local_temp_dir)}/生技??174号文/test.txt",
-            mode="r",
-        ) as file:
-            assert file.read() == "hello world"
+    if (
+        tosfs._is_hns_bucket(bucket)
+        and os.environ.get("HNS_DISABLE_SPECIAL_CHAR_TESTS") == "true"
+    ):
+        with tempfile.TemporaryDirectory() as local_temp_dir:
+            dir_2 = f"{local_temp_dir}/生技??174号文/"
+            dir_3 = f"{local_temp_dir}/生技**174号文/"
+            dir_4 = f"{local_temp_dir}/生技_=+&^%#174号文/"
+            os.makedirs(dir_2)
+            os.makedirs(dir_3)
+            os.makedirs(dir_4)
+            with open(f"{dir_2}/test.txt", "w") as f:
+                f.write("hello world")
+            tosfs.put(
+                local_temp_dir,
+                f"{bucket}/{temporary_workspace}",
+                recursive=True,
+                disable_glob=True,
+            )
+            assert tosfs.exists(
+                f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
+                f"/生技??174号文/"
+            )
+            assert tosfs.exists(
+                f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
+                f"/生技??174号文/test.txt"
+            )
+            assert tosfs.exists(
+                f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
+                f"/生技**174号文/"
+            )
+            assert tosfs.exists(
+                f"{bucket}/{temporary_workspace}/{os.path.basename(local_temp_dir)}"
+                f"/生技_=+&^%#174号文/"
+            )
+            with tosfs.open(
+                f"{bucket}/{temporary_workspace}/"
+                f"{os.path.basename(local_temp_dir)}/生技??174号文/test.txt",
+                mode="r",
+            ) as file:
+                assert file.read() == "hello world"
 
     # test let special-char dir as the lpath
     with tempfile.TemporaryDirectory() as local_temp_dir: