Implement ls API #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanghua
commented
Aug 16, 2024
| self.version_aware = version_aware | ||
| super().__init__(**kwargs) | ||
|
|
||
| def ls(self, path, detail=False, refresh=False, versions=False, **kwargs): |
There was a problem hiding this comment.
The versioned list has not been tested currently. It needs to wait until the r/w operation of the file is available. A TODO issue #11 has been recorded
yanghua
commented
Aug 16, 2024
Comment on lines
+135
to
+141
| "Key": bucket.name, | ||
| "Size": 0, | ||
| "StorageClass": "BUCKET", | ||
| "size": 0, | ||
| "type": "directory", | ||
| "name": bucket.name, |
There was a problem hiding this comment.
All the returned object schemas are currently aligned with s3fs as much as possible.
xianyinxin
reviewed
Aug 16, 2024
xianyinxin
reviewed
Aug 16, 2024
xianyinxin
reviewed
Aug 16, 2024
xianyinxin
reviewed
Aug 16, 2024
xianyinxin
reviewed
Aug 16, 2024
xianyinxin
reviewed
Aug 16, 2024
xianyinxin
reviewed
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📝
Implement ls API
Details
Describe more what you did on changes.
Bugfixes 🐛 (delete if dind't have any)
Checks