upath.implementations.local: Path.__init__ quirks on python 3.8-3.12

fsspec · Sep 3, 2024 · 50bd74e · 50bd74e
1 parent 36068bf
commit 50bd74e
Showing 1 changed file with 31 additions and 24 deletions.
diff --git a/upath/implementations/local.py b/upath/implementations/local.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import sys
 from pathlib import PosixPath
 from pathlib import WindowsPath
 from typing import Any
@@ -77,18 +78,21 @@ def __new__(
     ) -> Self:
         if not compatible_protocol("", path, *paths):
             raise ValueError("can't combine incompatible UPath protocols")
-        return super().__new__(cls, str(path), *map(str, paths))
-
-    def __init__(
-        self,
-        path: UPathLike,
-        *paths: UPathLike,
-        protocol: str | None = None,
-        **storage_options: Any,
-    ) -> None:
-        super().__init__(self, str(path), *map(str, paths))
-        self._protocol = ""
-        self._storage_options = {}
+        obj = super().__new__(cls, str(path), *map(str, paths))
+        obj._protocol = ""
+        obj._storage_options = {}
+        return obj
+
+    if sys.version_info >= (3, 12):
+
+        def __init__(
+            self,
+            path: UPathLike,
+            *paths: UPathLike,
+            protocol: str | None = None,
+            **storage_options: Any,
+        ) -> None:
+            super().__init__(str(path), *map(str, paths))
 
     protocol = UPath.protocol
     storage_options = UPath.storage_options
@@ -118,18 +122,21 @@ def __new__(
     ) -> Self:
         if not compatible_protocol("", path, *paths):
             raise ValueError("can't combine incompatible UPath protocols")
-        return super().__new__(cls, str(path), *map(str, paths))
-
-    def __init__(
-        self,
-        path: UPathLike,
-        *paths: UPathLike,
-        protocol: str | None = None,
-        **storage_options: Any,
-    ) -> None:
-        super().__init__(self, str(path), *map(str, paths))
-        self._protocol = ""
-        self._storage_options = {}
+        obj = super().__new__(cls, str(path), *map(str, paths))
+        obj._protocol = ""
+        obj._storage_options = {}
+        return obj
+
+    if sys.version_info >= (3, 12):
+
+        def __init__(
+            self,
+            path: UPathLike,
+            *paths: UPathLike,
+            protocol: str | None = None,
+            **storage_options: Any,
+        ) -> None:
+            super().__init__(str(path), *map(str, paths))
 
     protocol = UPath.protocol
     storage_options = UPath.storage_options