Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race conditions reported by go test -race #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix race conditions reported by go test -race #57

wants to merge 1 commit into from

Conversation

virtuald
Copy link
Contributor

@virtuald virtuald commented Apr 8, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.385% when pulling 1eb1803 on virtuald:tailer-race into e2ba841 on fstab:master.

@fstab
Copy link
Owner

fstab commented Apr 8, 2019

Thanks for the PR, I will have a look.

@fstab
Copy link
Owner

fstab commented Apr 27, 2019

Sorry for the delay. Would you mind to split it into two PRs? fswatcher_test.go has no conflicts and I would merge it right away. bufferedTailer_test.go has conflicts and I am still refactoring it because of #55, so I would like to postpone this until refactoring is done.

@fstab fstab force-pushed the master branch 3 times, most recently from 50bbec7 to 801df77 Compare January 2, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@virtuald @coveralls @fstab