Optimize IMC with Dedicated Solvers for Reachability and Fixed-Point #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #299
Things extra to consider:
The Fixed-Point solver was named
imcFpSolver
.Added
popAll()
method to theSolverBase
interface. This makes working with solvers easier. The user of the solver doesn't have to keep track of how many timespush()
was called when they just want to clear the 'stack'. This needs testing.In
ConfigToBoundedChecker.kt
, I used the same configuration for the Fixed-Point solver as the one for the itpSolver. This may need to be separated so the Fixed-Point solver can have its own configuration.