fix(CON-460): do not use Node.js built-in libraries

src/common/httpClient/serialize.test.ts

@@ -1,4 +1,4 @@
-import { serializeWithDatesAsIsoString } from './serialize';
+import { serializeWithDatesAsIsoString, isDate } from './serialize';
 
 describe('serializeWithDatesAsIsoString', () => {
   const now = new Date();
@@ -18,4 +18,13 @@ describe('serializeWithDatesAsIsoString', () => {
     expect(parsed.inner.bar).toEqual(now.toISOString());
     expect(parsed.inner.innerInner).toEqual(innerInner);
   });
+  it('accepts only a Date', () => {
+    expect(isDate(new Date())).toBeTruthy();
+    expect(isDate(new String())).toBeFalsy();
+    expect(isDate(undefined)).toBeFalsy();
+    expect(isDate(null)).toBeFalsy();
+    expect(isDate(0)).toBeFalsy();
+    expect(isDate('')).toBeFalsy();
+    expect(isDate({})).toBeFalsy();
+  });
 });

src/common/httpClient/serialize.ts

@@ -1,4 +1,14 @@
-import { isDate } from 'util/types';
+function objectToString(o: unknown): string {
+  return Object.prototype.toString.call(o);
+}
+
+function isObject(arg: unknown): arg is object {
+  return typeof arg === 'object' && arg !== null;
+}
+
+export function isDate(date: unknown): date is Date {
+  return isObject(date) && objectToString(date) === '[object Date]';
+}
 
 export function serializeWithDatesAsIsoString(key: string, value: unknown): unknown {
   return isDate(value) ? value.toISOString() : value;

src/fft-api/facility/fftFacilityService.ts

@@ -1,4 +1,3 @@
-import { setTimeout } from 'timers/promises';
 import {
   CarrierStatus,
   DefaultPickingTimesConfiguration,
@@ -20,6 +19,10 @@ import ActionEnum = ModifyShortpickAction.ActionEnum;
 import { Logger } from 'tslog';
 import { CustomLogger, QueryParams } from '../../common';
 
+const sleep = async (ms: number) => {
+  return new Promise((resolve) => setTimeout(resolve, ms));
+};
+
 export class FftFacilityService {
   private static readonly facilityCache = new Map<string, string>();
 
@@ -224,7 +227,7 @@ export class FftFacilityService {
             delay / 1000
           } seconds`
         );
-        await setTimeout(delay);
+        await sleep(delay);
         return this.disableShortPick(facilityId, retries - 1, delay * 2);
       }
       this.logger.error(`Disabling ShortPick for Facility '${facilityId}' failed ${err},`);